03-05-2005, 05:32 AM
Basically what I'm looking for is just for some people to look over my code and tell me where to make improvements, if that isn't too much trouble. I'm really happy that I'm learning CSS and XHTML, I love them. I actually converted this site, from tables to CSS..
Anyway, I look forward to all constructive criticism anyone can offer.
wwww.binvisions.com (index page)
In regards to the style, some of the fonts are so small I literally can't see them because they seem to be about 3px in size, e.g. "Last created auctions".
Your google adverts don't fit into the width of the parent space, try to expand it so that it does, because it looks wrong as it is.
The Full and Lite feature seems rather a pointless addition, it makes no real difference. I would have thought it may have switch it to a liquid layout, and with what is removed, there is no real difference made.
The menu also is tiny! Please can you make that a little bigger and remove the semi circles, they aren't nice.
As for the logo, it seems a little washed out, you do need to try and get more contrast in it.
You have a text field at the bottom of your page, with a button with Go as the text. I've no idea what that is meant to do? Try to make it clearer, have Search, or something instead to remove confusion...
I can see you've not used a graphic for the logo, which could be a bad thing if this is for a corporate site. They tend to have large manuals on what can and can't do. The fact that browsers could increase the size and alter kerning and its proportions would be seriously frowned at.
In terms of coding, first off, your code doesn't validate due to an extra UL being closed on line 106.
The code isn't at all laid out correctly, there is no real indenting to seperate parts, so it would make life harder for anyone who had the task of re-designing the site. Also, try to comment it, unless you have created a coders manual or it exists as server-side commenting.
None of the links work in Opera 7.54u1, so that may need fixing, but I'm not sure if you have reached that point as of yet.
Your CSS is better, marked up so I have no real negative comments about it.
03-05-2005, 08:44 PM
Wow, I really don't know what to do about all of this. All of the things you mentioned look fine on mine. I guess I need more help than I figured.
My Google ads fit for me, and I really don't understand how they wouldn't. I have a main container that is 750px wide. I then have 3 sub containers below the banner, from right to left they are 22% wide, 56% wide, and 22% wide (the google ad container). If you do the calculation that is 165px wide, the ad is 120px wide. I don't understand what I can do to fix this, as it looks fine for me in both FF and IE. Can anyone lend some help?
As for the fonts, I was under the impression that if you set them in percentages that they look the same on all browsers. I guess I'll have to up it a little bit though, thanks for bringing that to my attention. If anyone can explain how these percentages work, it would be greatly appreciated. Because obviously my understanding wasn't correct.
I'm sorry for how sloppy my code is, I'm cleaning it up as we speak, and planned on doing so before I tried to get help.. I forgot.
Thanks for taking the time to look at my code and point these problems out to me.
03-06-2005, 01:46 AM
evo pretty much touched based on the problems so i wont repeat what he said, as far as using percentages for fonts well something u may not have known is that its a percentage of the default font, so if no font-size is set in the body css then it will go off a percentage of a default font-size set in the browser
03-06-2005, 02:20 AM
I'll just give a quick list:
- Too many font faces used I think
- Too much space between logo and actual site body (including the menu)
- Font size is inconsitant too. The menu text is large, the blocks underneath are much smaller and those items have no vertical space between them (which makes it look like one big cluttered wad of text which I didn't want to read)
I don't mind the semi-circles, but I think they get too close to the menu text. More bottom padding on the items should fix that, though.
03-06-2005, 03:09 AM
Regardless of all the negatives, l think the page looks GREAT!! I didn't see any problems with font sizes (maybe that was fixed by the time l looked?). I can see putting in a flash player detection script, that'd be a great idea, but overall l love the way the page looks, very unique and original (in my opinion anyway)!
Great job on that, l can't wait until the actual site is up and running, l wanted to click around and have a look so badly!
03-06-2005, 03:17 AM
I just found:
http://www.binvisions.com/edepot/index.php by clicking around.
And looked around, l love the setup and the program myself.
Just a quick question, did you write that script yourself?