PDA

View Full Version : London flat site


WillGibson
03-04-2005, 01:33 AM
This is my second public site and first shot at xhtml and css layouts. Any comments are welcome. http://www.londonflat.biz/

Thanks everyone :thumbsup:

Will

NeilKelty
03-04-2005, 01:41 AM
Pull that text away from the sides that is annoying....umm more later

chilipie
03-04-2005, 07:07 AM
Pull that text away from the sides that is annoying....
<sarcasm>Nice to hear your in-depth review...</sarcasm>

Add more left/right padding on the paragraphs, definately. And perhaps the main content background should be white? Or, at least a paler blue. For some reason, the bottom/top nav don't seem to reach all the way across the page (FF 1.01, Win. XP Pro. SP2).

In IE, the nav "block" jumps up inside the main menu, at both the top and bottom. Also, there is a border around the amenities box, which isn't there in FF - screenie (http://img89.exs.cx/img89/5735/screenie4ig.jpg).

miggsy007
03-04-2005, 12:28 PM
Defo needs some margins. I'm not a big fan of the color scheme, it's a bit over powering (but as you all know I am a minimalist so don't listen to me if you don't want) and the design just seems plain. Can't you try and make it a bit more..... well, I'm not really sure but a bit more something.

Your code is pretty much perfect, it's laid out very well and is very easy to follow, the only thing is you have in-line styles which means it's not really following W3 standards because style blah blah content blah blah seperate etc.

Check out www.htmldog.com or www.alistapart.com or best of all www.csszengarden.com for a few ideas about using CSS.

Miggsy007

WillGibson
03-04-2005, 06:42 PM
Thanks for the input :)


Add more left/right padding on the paragraphs, definately. And perhaps the main content background should be white? Or, at least a paler blue. For some reason, the bottom/top nav don't seem to reach all the way across the page (FF 1.01, Win. XP Pro. SP2).

I added 5px of padding to #content and switched the background to white. I did try just making it a shade paler but that didn't look much better. I know most ppl stick with the color safe palette but at times like this I just wish I didn't need to. As for the nav bars, I had body level padding on right and left at 2px. The nav bars should now span the page.


In IE, the nav "block" jumps up inside the main menu, at both the top and bottom. Also, there is a border around the amenities box, which isn't there in FF.

Adding a border fixed the jumping nav block at the cost of a thicker nav bar, but I can live with that. As to the border around amenites, I see it in FF but it looks different in IE. Currently its set to border-style:ridge. I guess that looks different in FF...never noticed it before.

Defo needs some margins. I'm not a big fan of the color scheme, it's a bit over powering (but as you all know I am a minimalist so don't listen to me if you don't want) and the design just seems plain. Can't you try and make it a bit more..... well, I'm not really sure but a bit more something.

Your code is pretty much perfect, it's laid out very well and is very easy to follow, the only thing is you have in-line styles which means it's not really following W3 standards because style blah blah content blah blah seperate etc.

Check out www.htmldog.com or www.alistapart.com or best of all www.csszengarden.com for a few ideas about using CSS.

Miggsy007

I'll be moving the in-line styles into the css. I agree that its a plain site and I want to do something to correct that. I'll see what I can come up with :)

Any other comments are welcome!
Thanks again folks!

Will

NeilKelty
03-04-2005, 09:13 PM
<sarcasm>Nice to hear your in-depth review...</sarcasm>


Sorry...I was on here real quick before i ran off to study for a test...at least i gave 1 point :)

Scootertaj
03-04-2005, 10:00 PM
Looks much better now, good job!

JamieR
03-04-2005, 10:21 PM
Overall I like the site, but it feels a bit plain to me. I think it would benefit from a grayish background and smaller Arial text which had a colour apart from being black. However, the site is very easy to read, which is important - just needs the "sparkle".

Also, how about colouring the background of the #top div and having the font a different colour - maybe a similar colour as the border?

Another thing, on the contact page, the page is positioned differently than the other pages - in firefox at least.

miggsy007
03-04-2005, 10:51 PM
Site looks a bit better now mate. I would definately add some bigger margins though - give your content div a fixed width and then give it auto margins. You also declare the page as XHTML 1.1 - this means the <b> tag is depreciated and shouldn't be used.

Miggsy007

WillGibson
03-07-2005, 09:45 PM
Thanks for all the suggestions and comments everyone :)

I have removed all the in-line styles and depreciated tags (I think). Also added a background image, the client wanted knights in there somewhere.

I have to make this a last call for comments, its time to move to the next project. You've all been a huge help thanks again!

Will