[php]
<?php
require ('sdfsdfsdconnectsdqsd.php');
$letter = $_GET['letter'];
...
?>
No need, this is the only page that will use this particular connection.
But I still get errors:
Parse error: parse error, unexpected T_VARIABLE in C:\apache2triad\htdocs\index5.php on line 29
My new php code:
<?php
// Connect to the database server
$connect= @mysql_connect('localhost', 'root', 'DELETED') or die ('Unable to connect to the database server at this time.' );
// Select the database
@mysql_select_db('gamecube', $connect) or die('Unable to locate the cheats database at this time.' );
$letter = $_GET['letter'];
$game = $_GET['game'];
if (isset($game))
{
$sql = "SELECT games.gamename, authers.authername, cheats.cheattitle, cheats.cheattext FROM (cheats INNER JOIN games ON cheats.game=games.gameID) INNER JOIN authers ON cheats.auther=authers.autherID WHERE cheats.game =" . $game;
$result=mysql_query($sql) or die ('queryproblem');
if (mysql_num_row($result) >= 1){
while ($row = mysql_fetch_assoc($result)){
echo ('Cheat Title:' . $row['cheattitle'] . '<br>
Cheat Text:' . $row['cheattext'] . '<br> ');
}
} else {
echo 'No cheats';
}
}
else if (isset($letter))
{
$sql="SELECT gameID, gamename FROM games ORDER BY gamename asc WHERE gamename LIKE '".$letter."%'"
$result=mysql_query($sql) or die ('Queryproblem');
if (mysql_num_row($result) >= 1){
while ($row=mysql_fetch_assoc($result)){
echo ('
<a href="' . $_SERVER['PHP_SELF'] .'&game='. $row['gameID'] .'">Cheats for '. $row['gamename'] .'</a><br />
');
}
} else {
echo 'no games available';
}
}
else {
echo('
<a href="' . $_SERVER['PHP_SELF'] .'?letter=s">S</a><br>
<a href="' . $_SERVER['PHP_SELF'] .'?letter=b">B</a>
');
}
?>
That is not the way to look at it. Even if you only use the name, you should still store it inside a seperate table. Data should not be repeated (more updatingproblems) and selecting/filtering on an indexed numerical column is waaay faster then selecting/filtering on a stringcolunm.
Relational designs are also much more flexible : even if you now only use the name or only include the name inside you authertable, nothing guarantees that you wount add anything to it later on.
So it's better to leave it as it is.
Okay, you kinda lost me there. I didn't really want the author table because I don't need information on the author. I have phpBB and all the authors information is in its phpbb_users table. I also didn't want it because of the authorID because, even though that is a great way to assign a author to a cheat, I can't remember all the authorIDs and thier corresponding authors. But your right, I might need it in the future, and I could serch for a author with phpMyAdmin to find thier ID. I'll leave it...
You however need to change your columntypes
authorID, cheatID, gameID should all be of a numerical type (mediumint for instance), should be the primary key and should be the autonum column.
auther and game inside the cheat table, should be of the same columntype (mediumint) and you should create an index on them.
To make it fully normalised:
producer could probably be included inside the auther-table (best rename the authertable to persons or whatever) or else, you should set up a new table with only the producers and include the PK in your cheatstable as an indexed mediumint-column(just like the auther and game column).
Imagine that the producer changes his name --> this well then only require the update of 1 single field. + your db will be much faster when you use indexed numrical columns to filter on.
genre --> same here. Move to another table and only include the PK of that table here
release --> should probably be a numerical column.
I've changed authorID, cheatID, gameID to mediumint and they are the primary keys for their tables, but I couldn't see a autonum option, to make it a auto number. I looked in the dropdown box, but couldn't see it.
auther and game inside the cheat table are now mediumint, and they are an index.
As for the producer, I'm going to leave it in the game table, since the producer is the one the produces the game, it is near unheard-of that they will change thier company name unless they sold out. Even if that happened, I'll leave it to whatever it is since that was thier name when they produced it. Same for genre, although I don't know why I'm using it. I was going to use it to index the games title (like by letter, only this is by number) but I'm going to pass for now. And I changed the release to to date since it is a date that it was released. The only problem I had with MySQL is that I could find out how to autonum those colomns
Just to clean everything up, the MySQL tables:
Authors Table:
+------------+----------------+------+-----+---------+-------+
| Field | Type | Null | Key | Default | Extra |
+------------+----------------+------+-----+---------+-------+
| authorID | mediumint(255) | | PRI | 0 | |
| authorname | varchar(255) | | | | |
+------------+----------------+------+-----+---------+-------+
+----------+---------------+
| authorID | authorname |
+----------+---------------+
| 1 | XtremeGamer99 |
+----------+---------------+
Cheats Table:
+------------+----------------+------+-----+------------+-------+
| Field | Type | Null | Key | Default | Extra |
+------------+----------------+------+-----+------------+-------+
| cheatID | mediumint(255) | | PRI | 0 | |
| cheattitle | varchar(255) | | | | |
| cheattext | varchar(255) | | | | |
| cheatdate | date | | | 0000-00-00 | |
| auther | mediumint(255) | | MUL | 0 | |
| game | mediumint(255) | | MUL | 0 | |
+------------+----------------+------+-----+------------+-------+
+---------+------------+-----------------------------------+------------+--------+------+
| cheatID | cheattitle | cheattext | cheatdate | auther | game |
+---------+------------+-----------------------------------+------------+--------+------+
| 1 | Hi there | Hi There. Is this script working? | 2004-08-06 | 1 | 1 |
+---------+------------+-----------------------------------+------------+--------+------+
Games Table:
+----------+----------------+------+-----+------------+-------+
| Field | Type | Null | Key | Default | Extra |
+----------+----------------+------+-----+------------+-------+
| gameID | mediumint(255) | | PRI | 0 | |
| gamename | varchar(255) | | | | |
| producer | varchar(255) | | | | |
| genre | varchar(255) | | | | |
| release | date | | | 0000-00-00 | |
+----------+----------------+------+-----+------------+-------+
+--------+----------+----------+-------+---------+
| gameID | gamename | producer | genre | release |
+--------+----------+----------+-------+---------+
| 1 | sonic | N/A | N/A | N/A |
+--------+----------+----------+-------+---------+
Going back to the error, I've searched it and couldn't find anything wrong...