...

View Full Version : Site Review!



lnxusr86
01-11-2004, 11:48 AM
http://www.i-guru.tk/ - This is my first personal website, its not yet complete but i would like a review of it so far so i can improve it.

ionsurge
01-11-2004, 12:20 PM
You've got the following issues in your site:

1. Your site does not validate @ xhtml 1.0.
2. You used frames.
3. You specified the font size - a big no no.
4. You have included your styles in the actual page, another no no.
5. Ditto but with scripts.
6. You've added a preloader - it is more annoying than anything, and sometimes it doesn't go away.
7. Your menu overlaps on to that picture of the server, or whatever it may be.
8. You've used a fixed layout.
9. The link to the W3C CSS validator should be:

<a href="http://jigsaw.w3.org/css-validator/check/referer">xxx</a>
What you have done doesn't validate the css on your page.
10. You've got a sp error, Curriculum Vitae is what it is meant to be, not Curiculam Vitae.
11. Latest, latest what? Try to say what a menu item points to. It removes any sense of confusion.
12. The menu isn't very neat, try using same-width tabs, or decent padding on both sides. The way it is just looks sort of messy.
13. It doesn't fit into an 800 x 600 screen - get a horizontal scrollbar.

In terms of design, it does look fine, but it needs all the above ammending.

:)

------------------------------------
Edit: By the way, never say that you love your own designs...

skinme!
01-11-2004, 02:03 PM
Just a quickie ionsurge: Why is inline CSS a no-no? I always use external CSS so that the style sheet can be cached and to reduce the html filesize. Is that what you mean? Or are there some other implications?

ionsurge
01-11-2004, 02:27 PM
Exactly as you say, you only then need to load it once, instead of wasting time loading it every time you go to a page. There aren't any other implications, apart from the possibility of a lack of continuity.

:)

lnxusr86
01-11-2004, 04:32 PM
oooh boy lol, okay thankyou for u comments i'll try and fix the problems and by the way i havnt used frames, ive used the object tag instead which is supported by xhtml where as iframe isnt

Paul Jr
01-11-2004, 06:54 PM
You're using tables for your layout.
You're using JS to do something that could be accomplished much more easily with CSS
Spacer .gif's... Ick
You have an external stylesheet -- excellent, but you still have all, or some, of your styles embedded -- bad.
There are all sorts of weird spaces and breaks in your images. I'm using Moz FireBird 0.7
The preloader isn't necessary, and quite annoying.
You have a linked image on your site, whose appearance indicates the site is authored with Valid XHTML -- which it is not.

lnxusr86
01-13-2004, 05:24 PM
There are all sorts of weird spaces and breaks in your images. I'm using Moz FireBird 0.7

and how do i fix that?

me'
01-13-2004, 06:39 PM
Originally posted by skinme!
Just a quickie ionsurge: Why is inline CSS a no-no? I always use external CSS so that the style sheet can be cached and to reduce the html filesize. Is that what you mean? Or are there some other implications? *cough*

Seperation and style and content? The entire driving motive behind XML and CSS?

mindlessLemming
01-14-2004, 12:39 AM
Originally posted by lnxusr86
and how do i fix that?

You go to Mozilla.org (http://www.mozilla.org) and get a better browser for testing your work.


I've attached a screen shot of what it looks like in Moz 1.6

skinme!
01-15-2004, 12:13 AM
Originally posted by me'
*cough*

Seperation and style and content? The entire driving motive behind XML and CSS?
Separation of style and content does not have to mean a two-file solution. Inline CSS in the HEAD of a document is still style separated from content.

Paul Jr
01-15-2004, 04:47 AM
Yes, but embedding your styles is shooting yourself in the foot. One of the advantages with CSS, is using an external stylesheet that only has to be loaded once, thus cutting down the loading time of your site. If you're just embedding it all, you're not helping, and you might even be hurting.

skinme!
01-15-2004, 08:59 AM
Which is what I said in my original question. ;) I apologise for the stupid question. It just occurred to me that inline isn't as big a no-no as no CSS.

lnxusr86
01-15-2004, 06:20 PM
Originally posted by mindlessLemming
You go to Mozilla.org (http://www.mozilla.org) and get a better browser for testing your work.


I've attached a screen shot of what it looks like in Moz 1.6

yeah i got mozzilla firebird... im staring at the screen what to i do to fix the prob i mean in the coding like...

me'
01-16-2004, 05:23 PM
Originally posted by skinme!
Separation of style and content does not have to mean a two-file solution. Inline CSS in the HEAD of a document is still style separated from content. Inline styles are applied using the style attribute of elements. Styles contained within <style> and </style> are embedded, not inline. Hope that clears things up.

skinme!
01-17-2004, 09:58 AM
Thanks for clearing that up.

lnxusr86
01-17-2004, 09:43 PM
any other things before i begin redesigning?

mindlessLemming
01-18-2004, 01:13 AM
Well, besides your code, which I feel relies on javascript for absolutely no reason, (other than your beloved pre-loader:o ) -
Your navigation is quite tired and dull, as well as being a jumbled mess of tables and js calls without any option for those with javascript disabled, such as myself.

It would far more managable/accessible/less code/better looking
if you used an unordered list <ul>with links <a> nested inside the list elements <li>. You can see a very basic example on my links site (http://studentwork.qantm.com.au/akrespanis/home.cfm) , and if you go to the CSS links section there are far better examples from places like a list apart, SimpleBits and others.

Also, when you redo your nav. with <ul> and CSS, put equal padding on left and right of <a> text so as to centre the text within it's display block. Perhaps a 1px solid border around each button slightly darker than its background as well as a narrow margin to seperate each would make them more aestheticly pleasing.
And don't forget to assign a different colour to a:hover{color:#......}
so the link text changes colour on hover. This is an important visual clue that should not be removed.

!important
If you really want to keep the sliced images and lay the page out in the traditional way, use Adobe ImageReady 7 for the slicing/exporting.
It has options which allow you to get it to make all slices <div>'s and all styling CSS. This is a fantastic option for those trying to make the transition from chopped up tables to flowing em's or wherever.
Just make sure you set it to ALL LOWERCASE tags and attributes and to make the slices background images of their parent div, allowing you to freely add other elements into the div later.

SOme of this may not have made much sense, but I wrote the second half assuming you had gone and done everything I recommended in the first half:D

Have fun redesigning,
Andrew

**edit: Image Ready 7. Don't remember if 3 could as well. (ver.3 shipped with Photoshop 6)



EZ Archive Ads Plugin for vBulletin Copyright 2006 Computer Help Forum