...

View Full Version : Form Validation help



Demon Templates
12-20-2011, 07:55 PM
HI all, I have a contact for that requires validating for a number of things. It validates Required for all parts of the form however fine.

My question is how can I ensure the client fills out the form fully. For instance, here in the UK we use 11 digits for phone numbers, but the form will validate if the clint enters just 1, so how can I ensure the customer actually enters all 11.

Here is the javascript I am using

function isFilled(str){ return (str != ""); }
function isEmail(str) { return (str.indexOf(".") > 2) && (str.indexOf("@") > 0); }
function isDigital(str) { return(parseFloat(str,10)==(str*1)); }
function isCurrency(val) { var re = /^(\$?\d+\$?|\$?\d+\.\d+\$?)$/; return (re.test(val)); }
function ValidForm(form) {
var field, i;
var req = new Array(10);
var email = new Array(1);
var digits = new Array(1);
var currs = new Array(0);
req[0] = "rw_First_Name";
req[1] = "rw_Last_Name";
req[2] = "re_Email";
req[3] = "rd_Mobile_Number";
req[4] = "r_Hair_Service";
req[5] = "r_Stylist";
req[6] = "r_Preferred_Day";
req[7] = "r_Preferred_Date";
req[8] = "r_Month";
req[9] = "r_Preferred_Time";
email[0] = "re_Email";
digits[0] = "rd_Mobile_Number";

for (i=0;i<10;i++) {
eval("field = form." + req[i]);
if (!isFilled(field.value)) {
alert("Field '" + field.title + "' is required to be filled in before successful submission.");
field.focus();
return false;
break;
}}
for (i=0;i<1;i++) {
eval("field = form." + email[i]);
if (!isEmail(field.value)) {
alert("Field '" + field.title + "' is required to be filled in with valid email addresses before successful submission.");
field.focus();
return false;
break;
}}
for (i=0;i<1;i++) {
eval("field = form." + digits[i]);
if (!isDigital(field.value)) {
alert("Field " + field.title + " is required to be filled in only with digits (0-9) and decimal point before successful submission.");
field.focus();
return false;
break;
}}
for (i=0;i<0;i++) {
eval("field = form." + currs[i]);
if (!isCurrency(field.value)) {
alert("Field " + field.title + " is required to be filled in only with digits (0-9) a decimal point, or a dollar sign before successful submission.");
field.focus();
return false;
break;
}}
return true; }

Philip M
12-21-2011, 09:05 AM
Form validation which simply checks for a blank field is barely worthy of the name, and virtually useless, as even a single space, an X or a ? will return false, that is pass the validation. Numeric values, such as zip codes and phone numbers, should be validated as such. Ditto email addresses. This topic has been covered many times before in this forum.

To be candid, you would be best advised to ditch that elderly generic (and inefficient) validation script and write a proper one.

Not all UK telephone numbers are 11 digits. e.g. (01204) xxxxx Bolton

For phone validation see e.g. http://www.codingforums.com/showthread.php?t=156981



Quizmaster: The small primates called lemurs are native to which large island off the coast of Africa?
Contestant: Argentina.

Demon Templates
12-21-2011, 09:22 AM
Thanks Philip for your reply, but I do not see how your advice is meant to hellp in what I am asking?

Philip M
12-21-2011, 09:45 AM
Thanks Philip for your reply, but I do not see how your advice is meant to hellp in what I am asking?

You asked how to validate a telephone number and I pointed you to a thread in this forum. I also pointed out that form validation had been covered very many times in this forum. And I also pointed out that your script was generic, and did not allow for proper validation without very considerable modifications.

What further help do you want? You cannot reasonably expect people to provide you with an oven-ready solution when 9 different fields are involved.



EZ Archive Ads Plugin for vBulletin Copyright 2006 Computer Help Forum