Calling functions in Javascript

Hello all here is a more intelligent question. This one is just on an exercise I am doing.

I have to call a function using parameter values.

my main function is this



function showResults(race,name,party,votes)

or just

function showResults




in the next lines below

i have to call the function

is this the right way




<script type="text/javascript">
{
showResults=("race[0],name1,party1,votes1");

}
</script>


or should it be without the { and }

like this?



script type="text/javascript">

showResults=("race[0],name1,party1,votes1");


</script>


or is it like this


script type="text/javascript">

showResults(race[0],name1,party1,votes1);


</script>




Thanks all, what would be the proper method

Thanks

or is it like this


script type="text/javascript">

showResults(race[0],name1,party1,votes1);


</script>





Thanks

Yes. Items in quotes are literals.

var x = "myname" // assigns the literal value myname to the variable x.
var x = myname // assigns the current value of the variable myname to the variable x.

You wish to pass the values of the four variables race[0],name1,party1,votes1 to your function. race[0] represents the first index value in the array named race.

The braces { and } are used to surround the commands that are to be run as a block such as functions, for loops, if statements etc., or an object literal such as var myObject = {}

Thank you so much,
would this be properly written for this format of Call Function

<script type="text/javascript">

showResults("race[0]","name1","party1","votes");
showResults("race[1]","name2","party2","votes2");
showResults("race[2]","name3","party3","votes3");
showResults("race[3]","name4","party4","votes4");
showResults("race[4]","name5","party5","votes5");

</script>


thank you

HOW can you READ what Philip wrote and then completely ignore him??????????



or is it like this
script type="text/javascript">
showResults(race[0],name1,party1,votes1);
</script>

Yes.


Do you see any quote marks in there? The version that Philip told you clearly is the correct one??? Or did you somehow read "Yes" to mean "No"??

ok so then now i have

<script type="text/javascript">

showResults(race[0],name1,party1,votes);
showResults(race[1],name2,party2,votes2);
showResults(race[2],name3,party3,votes3);
showResults(race[3],name4,party4,votes4);
showResults(race[4],name5,party5,votes5);

</script>


correct i assume

correct i assume
The syntax is correct.

Whether or not the semantics are correct is another question.

I find it strange that you would have an array for the race but then individual variable name for the other values. Why not 4 arrays?

But yes, the syntax is correct.

The exercise i am working on says this.

" call the showResults() function using race[0], name1,party1 and votes1 as parameter values, repeat the previous command for the remaing four races useing race[1] through race [4]. as parameter value, for race parameter, party2 through party5 for party parameter....etc"

so what would make more sense on this one?

Okay...if that's what it says. That's what you do.

seems like it now i have to debug the program.
i post a second reply about firebug

I am getting a firebug message for this line


var item = Math.round((item/sum)*100); // script element to get the percentage

a missing ; before statement

but i have a ; in it
what could be the situation?

Probably from the line or lines above. That line looks fine.

Well here is the full function i created. I was working this with someone else.

I just keep getting an error of saying i need to input a ; somewhere

from this code.

function totalVotes(votes){ // script element that will calculate the array
var total = 0;
for (var i = 0; i < votes.length; i++)
{
total = total + votes[i];
}
return total;
}

function calcPercent(item,sum) { // script element to calculate the percentage which is rounded to the nearest integer
var item = Math.round((item/sum)*100); // script element to get the percentage
return item;
}
calcPercent();

Can anyone first hand spot if i missed a ; anywhere?

This may be confusing things.

var item = Math.round((item/sum)*100);
maybe change to
var items = Math.round((item/sum)*100); and return items

Well *THIS* is clearly an error:

calcPercent();

The function requires two arguments. You are passing none.

SO of course it goes *KABLOOEY*.

Try doing
calcPercent( 1, 3 );

and see what you get.

Thanks for the tip, well made some changes as recommended, so far no results yet, i may have made more mistakes in rest of my file, i will look over the other arrays loops and functions i will have more questions again