Trouble With admin editing

[Crash1hd]

Ok here is the code for some reason it wont let me update my db file???

Sub Edit(Conn)

Dim userid, username, pass, email, First_Name, Last_Name, Address, City, Province, PostalCode, Day_Phone_A, Day_Phone_B, Day_Phone_C, Night_Phone_A, Night_Phone_B, Night_Phone_C, Clearance, confirmed

userid = CInt(Request.Form("userid"))
username = Replace(Request.Form("username"), "'", "''")
pass = Replace(Request.Form("pass"), "'", "''")
email = Replace(Request.Form("email"), "'", "''")
First_Name = Replace(Request.Form("First_Name"), "'", "''")
Last_Name = Replace(Request.Form("Last_Name"), "'", "''")
Address = Replace(Request.Form("Address"), "'", "''")
City = Replace(Request.Form("City"), "'", "''")
Province = Replace(Request.Form("Province"), "'", "''")
PostalCode = Replace(Request.Form("PostalCode"), "'", "''")
D_Phone_A = Replace(Request.Form("D_Phone_A"), "'", "''")
D_Phone_B = Replace(Request.Form("D_Phone_B"), "'", "''")
D_Phone_C = Replace(Request.Form("D_Phone_C"), "'", "''")
N_Phone_A = Replace(Request.Form("N_Phone_A"), "'", "''")
N_Phone_B = Replace(Request.Form("N_Phone_B"), "'", "''")
N_Phone_C = Replace(Request.Form("N_Phone_C"), "'", "''")
Clearance = CInt(Request.Form("Clearance"))
confirmed = Request.Form("confirmed")

If confirmed = "True" Then confirmed = "-1"
If confirmed = "False" Then confirmed = "0"

SQL = "Update members Set username = '"&username&"', [pass] = '"&pass&"', email = '"&email&"', First_Name = '"&First_Name&"', Last_Name = '"&Last_Name&"', Address = '"&Address&"', City = '"&City&"', Province = '"&Province&"', PostalCode = '"&PostalCode&"', D_Phone_A = '"&D_Phone_A&"', D_Phone_B = '"&D_Phone_B&"', D_Phone_C = '"&D_Phone_C&"', N_Phone_A = '"&N_Phone_A&"', N_Phone_B = '"&N_Phone_B&"', N_Phone_C = '"&N_Phone_C&"'"
SQL = SQL & ", Clearance = "&Clearance&", confirmed = '"&confirmed&"' Where userid = "&userid&""

Set RS = Conn.Execute(SQL)

CleanUp()

Response.Redirect "/Login/admin.asp"

End Sub

[Crash1hd]

the add works fines below but the edit which is above doesnt

Sub Add(Conn)

Dim UserName, pass, email, First_Name, Last_Name, Address, City, Province, PostalCode, D_Phone_A, D_Phone_B, D_Phone_C, N_Phone_A, N_Phone_B, N_Phone_C, Clearance, confirmed, SQL

UserName = Replace(Trim(Request.Form("username")), "'", "''")
pass = Replace(Trim(Request.Form("pass")), "'", "''")

email = Trim(Request.Form("email"))
First_Name = Trim(Request.Form("First_Name"))
Last_Name = Trim(Request.Form("Last_Name"))
Address = Trim(Request.Form("Address"))
City = Trim(Request.Form("City"))
Province = Trim(Request.Form("Province"))
PostalCode = Trim(Request.Form("PostalCode"))
D_Phone_A = Trim(Request.Form("D_Phone_A"))
D_Phone_B = Trim(Request.Form("D_Phone_B"))
D_Phone_C = Trim(Request.Form("D_Phone_C"))
N_Phone_A = Trim(Request.Form("N_Phone_A"))
N_Phone_B = Trim(Request.Form("N_Phone_B"))
N_Phone_C = Trim(Request.Form("N_Phone_C"))

Clearance = Trim(Request.Form("Clearance"))
confirmed = Trim(Request.Form("confirmed"))

If UserName = "" Or pass = "" Or email = "" Or First_Name = "" Or Last_Name = "" Or Address = "" Or City = "" Or Province = "" Or PostalCode = "" Or D_Phone_A = "" Or D_Phone_B = "" Or D_Phone_C = "" Or N_Phone_A = "" Or N_Phone_B = "" Or N_Phone_C = "" Or Clearance = "" Or confirmed = "" Then Response.Redirect "/login/admin.asp"

SQL = "Insert Into members (UserName, [pass], email, First_Name, Last_Name, Address, City, Province, PostalCode, D_Phone_A, D_Phone_B, D_Phone_C, N_Phone_A, N_Phone_B, N_Phone_C, Clearance, confirmed) Values('"&UserName&"', '"&pass&"','"&email&"', '"&First_Name&"', '"&Last_Name&"', '"&Address&"', '"&City&"', '"&Province&"', '"&PostalCode&"', '"&D_Phone_A&"', '"&D_Phone_B&"', '"&D_Phone_C&"', '"&N_Phone_A&"', '"&N_Phone_B&"', '"&N_Phone_C&"', '"&Clearance&"', '"&confirmed&"')"

Conn.Execute(SQL)

CleanUp()

Response.Redirect "/Login/admin.asp"

End Sub

also the delete doesnt work??

Sub Delete(Conn)

Dim userid, SQL

userid = CInt(Request.Form("userid"))

SQL = "Delete * From members Where userid = "&userid&""
Conn.Execute(SQL)

CleanUp()

Response.Redirect "/Login/admin.asp"

End Sub

[raf]

Lets start with the insert.

insert theis right before the 'Conn.Execute(SQL)'

response.write SQL
response.end

Then browse to that page. The sql string will be printed. Check if all values are correct.
Do you get an errormessage?

(Note, can't you use a for each element in group loof for the formprocessing?)

[Crash1hd]

Thanks raf I was able to fix it yet I dont remember how! lol figures