...

View Full Version : Error In syntax



bucket
10-19-2009, 11:45 PM
I got this error:


Parse error: syntax error, unexpected '>' in /home/bucket/public_html/inc/func.ban.php on line 56



<?php
error_reporting(E_ALL);
ini_set('display_errors', '1');
// func.ban.php
// checks the ip to see if it is banned
function checkban($ip)
{
// querys database
$q = mysql_query("SELECT * FROM `banned` WHERE `ip` = '$ip' LIMIT 1");
$get = mysql_num_rows($q);
// if found
if ($get == "1")
{
// deny user access
$r=mysql_fetch_array($q);
die("You have been banned from this website for $r[reason].");
}
}
// places a ban in the database
function addban($ip,$reason,$legnth)
{
// get current time
$time = time();
// inserts code into database
$insert = mysql_query("INSERT INTO `banned` (`ip`,`time`,`long`,`reason`) VALUES ('$ip', '$time', '$legnth', '$reason')") or die("Could not add ban.<br />".mysql.error()."");
echo "The ip address, $ip, has been added to the ban list.";
}
// deletes a ban from the database
function delban($id)
{
// runs a delete query
$delete = mysql_query("DELETE FROM `banned` WHERE `id` = '$id' LIMIT 1") or die("Could not remove ban.<br />".mysql.error()."");
echo "The ip address has been removed from the ban list.";
}
// lists the bans in the ban admin
function listbans()
{
// link to add ban
echo "<a href='accounts-banned.php?x=add'>Add Ban</a><p>";
echo "<table class=\"gridtable\">
<thead>
<tr>
<th scope=\"col\" align=\"center\">IP Address</th>
<th scope=\"col\" align=\"center\">Reason</th>
<th scope=\"col\" align=\"center\">Legnth</th>
</tr>
</thead><tbody>";
// loop to show all band
$query = mysql_query("SELECT * FROM `banned` ORDER BY time DESC");
$num = mysql_num_rows($query);
if ($num)
{
while ($r=mysql_fetch_array($query))
{
echo "<tr align=\"center\">;
echo "<td>$r[ip]</td>";
echo "<td>$r[reason]</td>";
echo "<td><a href='accounts-banned.php?x=delete&id=$r[id]'>Delete</a></td>";
echo "</tr>;
}
}
echo "</tbody></table>";
}
?>

Line 56 is:

echo "<td>$r[ip]</td>";

Whats the problem?

mlseim
10-20-2009, 12:02 AM
These ...

$r[ip]

Need to be variables like this ... with single quotes.

$r['ip']

Where the single quote will interfere with your HTML tag, use brackets:
echo "<td><a href='accounts-banned.php?x=delete&id={$r['id']}'>Delete</a></td>";

This line:
echo "<tr align=\"center\">;

Is missing a quote ...
echo "<tr align=\"center\">";

Legnth is spelled "Length".

Not sure what other problems there might be.



EZ Archive Ads Plugin for vBulletin Copyright 2006 Computer Help Forum