Shell script problem

Hi can someone tell me whats wrong with the following script i made:
#!/bin/sh
file1=$1
file2=$2
if [ $# = 2 && -e $file1]
then
if [ -e $file1 ]
then
echo "File 1 is" $file1
echo "File 2 is" $file2
cp $file1 $file2
else
echo "ERROR: File does not exist!"
fi
else
echo "ERROR: Not enough command line arguments!"
fi



The problem is:

philip@philip-laptop:~/Desktop$ sh copy.sh test.java test2.java
[: 16: missing ]
ERROR: Not enough command line arguments!

The reason is most likely that $# is 3 not 2 because the name of the script is passed in as the first command line argument. Echo out $# and see.

Hi can someone tell me whats wrong with the following script i made:
#!/bin/sh
file1=$1
file2=$2
if [ $# = 2 && -e $file1]
then
if [ -e $file1 ]
then
echo "File 1 is" $file1
echo "File 2 is" $file2
cp $file1 $file2
else
echo "ERROR: File does not exist!"
fi
else
echo "ERROR: Not enough command line arguments!"
fi



The problem is:

philip@philip-laptop:~/Desktop$ sh copy.sh test.java test2.java
[: 16: missing ]
ERROR: Not enough command line arguments!


why don't you use cp -i ?

The reason is most likely that $# is 3 not 2 because the name of the script is passed in as the first command line argument. Echo out $# and see.
no, $# is 2 not 3, 'program name' is not counted here

best regards

at this line:

if [ $# = 2 && -e $file1]

do you need a space near the end to make it $file1 ] ?

Its been quite a while since I've done any shell scripting, but I do remember it being picky.