PDA

View Full Version : Other coding affecting scripts?

Mandie
08-11-2008, 06:59 PM
I apologize if this is in the wrong section. There's probably a simple solution to this issue I'm having, but I deal more with graphics - not coding. Anyways, I own a general message board and recently I disovered that my scripts won't open in their own windows. I'm assuming one of my staff members messed around with my header template without telling me, because now nothing opens up. This is my whole header template, I just want to know if there's anything in here that would disable my scripts from working:

<SCRIPT LANGUAGE="JavaScript">
<!-- Idea by: Nic Wolfe -->
<!-- This script and many more are available free online at -->
<!-- The JavaScript Source!! http://javascript.internet.com -->
<!-- $versionlong -->
<!-- Build: $versionbuild -->
<!-- $versioncompany -->
<!-- www.aventure-media.co.uk : www.xmbforum.com -->
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html>
<head>

<!-- Begin
function popUp(URL) {
day = new Date();
id = day.getTime();
eval("page" + id + " = window.open(URL, '" + id + "', 'toolbar=0,scrollbars=0,location=0,statusbar=0,menubar=0,resizable=0,width=300,height=500');");
}
// End -->
</script></script>

<meta http-equiv="Content-Type" content="text/html; charset=$charset" />
<title>$bbname $threadSubject - $versionlong</title>
$css
<script language="JavaScript" type="text/javascript" src="./include/header.js"></script>
<script language="JavaScript" type="text/javascript" src="./include/headerlinks.js"></script>


</head>
<body text="$text">
$bbcodescript
$attachscript

<a name="top"></a>

<font class="smalltxt"><br></font>
<table cellspacing="0" cellpadding="0" border="0" width="600" align="center">
<tr>
<td bgcolor="black"><table border="0" cellspacing="1" cellpadding="0" width="100%">
<tr>
<td width="100%" bgcolor="$altbg1"><table border="0" width="100%" cellpadding="0" cellspacing="0">
<tr>
<td valign="top" rowspan="0">$logo</td>
</tr>
</table></td>
</tr>

<tr>
<td class="navtd">
<table width="100%" cellpadding="2" cellspacing="0">
<tr>
<td class="navtd"><font class="smalltxt"><center><a href="http://www.voguemb.net/faq.php?page=forumrules"><b>RULES</b></a> <b>▪</b> <a href="http://www.voguemb.net/portal.php"><b>PORTAL</b></a> <b>▪</b> <a href="http://www.voguemb.net/index.php?showforums"><b>FORUMS</b></a> <b>▪</b> <a href="http://www.voguemb.net/faq.php"><b>FAQ</b></a> <b>▪</b> <a href="http://www.voguemb.net/staff_page.php"><b>STAFF</b></a> <b>▪</b> <a href="http://www.voguemb.net/application.php"><b>APPLICATIONS</b></a> <b>▪</b> <a href="http://www.voguemb.net/misc.php?action=search"><b>SEARCH</b></a> <b>▪</b> <a href="http://www.voguemb.net/themes.php"><b>THEMES</b></a> <b>▪</b> <a href="http://voguemb.net/avatars.php"><b>AVATARS</b></a>
</center></td>

</tr>
</table></td>
</tr>
<tr>
<td class="navtd">
<table width="100%" cellpadding="2" cellspacing="0">
<tr>
<td bgcolor="$altbg1"><font class="smalltxt"><center><a href="http://www.voguemb.net/misc.php?action=online"><b>WHO'S ONLINE</b></a> <b>▪</b> <a href="http://www.voguemb.net/shop.php"><b>BOUTIQUE</b></a> <b>▪</b> <a href="http://www.voguemb.net/misc.php?action=list"><b>MEMBERS</b></a> <b>▪</b> <a href="http://www.voguemb.net/activity.php"><b>TOPIC ACTIVITY</b></a> <b>▪</b> <a href="http://www.voguemb.net/bday.php"><b>BIRTHDAYS</b></a> <b>▪</b> <a href="http://www.voguemb.net/stats.php"><b>STATS</b></a> <b>▪</b><a href="http://www.voguemb.net/shop_bank.php"> <b>BANK</b></a> <b>▪</b> <a href="http://www.voguemb.net/extras.php"> <b>EXTRAS</b></a>

</tr>
</table></td>
</tr>
$listusersvar
</table></td>
</tr>
</table>
<br />


<table cellspacing="$borderwidth" cellpadding="0" border="0" width="$tablewidth" align="center" bgcolor="$bordercolor">
<tr>
<td><table width="100%" cellspacing="0" cellpadding="0">
<tr>
<td align="left"<td class="nav" style="padding-bottom: 2px" bgcolor="$altbg1">&nbsp;[$lastvisittext]</td>
<td align="right"<td class="nav" style="padding-bottom: 2px" bgcolor="$altbg1">$notify</td>
</tr>
</tr>
</table></td>
</tr>
<td class="navtd">
<table width="100%" cellpadding="0" cellspacing="0">
<tr>
<td class="nav" style="padding-bottom: 1px" bgcolor="$altbg2">&nbsp;<a href="index.php">$bbname</a>&nbsp;$navigation</td>
<td align="right" bgcolor="$altbg2" ><a href="#bottom"><img src="$imgdir/arrow_dw.gif" border="0" alt="$lang[gotobottom]" /></a></td></td>
</tr>
</table></td>
</tr>
<tr>
<td class="navtd">
<table width="100%" cellpadding="4" cellspacing="0">
<tr>
<td class="nav" style="padding-bottom: 3px" bgcolor="$altbg1" align="left">U2U's: $newu2umsg</td> </td>

<td "nav" style="padding-bottom: 3px" bgcolor="$altbg1" align="right">$quickjump</td>
</tr>
</table></td>
</tr>
</table></td>
</tr>
</table>
</table>
</td>
</tr>
</table>

<br />

$headerads

Thanks.
ninnypants
08-11-2008, 07:18 PM
This whole section right here

<SCRIPT LANGUAGE="JavaScript">
<!-- Idea by: Nic Wolfe -->
<!-- This script and many more are available free online at -->
<!-- The JavaScript Source!! http://javascript.internet.com -->
<!-- $versionlong -->
<!-- Build: $versionbuild -->
<!-- $versioncompany -->
<!-- www.aventure-media.co.uk : www.xmbforum.com -->
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html>
<head>

<!-- Begin
function popUp(URL) {
day = new Date();
id = day.getTime();
eval("page" + id + " = window.open(URL, '" + id + "', 'toolbar=0,scrollbars=0,location=0,statusbar=0,menubar=0,resizable=0,width=300,height=500');");
}
// End -->
</script></script>

Your script tag opens before your document then once your are inside your document you don't open the script tag in the head and you have an extra closing script tag. Try replacing that section with this

<!-- Idea by: Nic Wolfe -->
<!-- This script and many more are available free online at -->
<!-- The JavaScript Source!! http://javascript.internet.com -->
<!-- $versionlong -->
<!-- Build: $versionbuild -->
<!-- $versioncompany -->
<!-- www.aventure-media.co.uk : www.xmbforum.com -->
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html>
<head>
<SCRIPT LANGUAGE="JavaScript">
<!-- Begin
function popUp(URL) {
day = new Date();
id = day.getTime();
eval("page" + id + " = window.open(URL, '" + id + "', 'toolbar=0,scrollbars=0,location=0,statusbar=0,menubar=0,resizable=0,width=300,height=500');");
}
// End -->
</script>
Nile
08-11-2008, 07:21 PM
You also want to make sure that your using type="text/javascript" instead of language="javascript". The difference is that one is old and outdated. So you can include both, but I suggest type="text/javacript". Of course, since I'm telling you to use the one with type="tex.... its the newer one.
ninnypants
08-11-2008, 07:32 PM
@nile good catch I didn't notice that