...

View Full Version : Still struggling with this site. Things are looking up now.



effpeetee
07-18-2008, 06:19 PM
http://exitfegs.co.uk/Angela1.htm

This site I need to improve for my church. As it stands it's awful. At least I think so and I have almost zero artistic skills. It is from a word 2003 document, converted with their 'save as web page' facility.

The code is bl--dy awful and I cannot begin to edit it. Some advice as to what to do ( I've even contemplated suicide. - only joking.) but I do have an obligation to help with this, even though my coding skills are almost at the same level as my artisic ones.

General guidance would be much appreciated. I can't guarantee a heavenly reward, but you never know!

Frank

jerry62704
07-18-2008, 07:21 PM
You might run it through a validater. There are 39 errors.

Things I would do include changes from:
<p align="center" class="style2"><span class="style5"><center>LIGHT OF THE HARVEST</center></span></p>
to:
<p class="style2 style5">LIGHT OF THE HARVEST</p>
putting the center in either style2 or 5. As style2 is a center, it shouldn't be needed elsewhere. And one line is better than two (as displayed here).

Further, the styles should be in an external sheet and validated. I'd be interested in what "~" (lines 24, 25, 34) does.

The last image overlays text, but I don't know if you intended that or not.

effpeetee
07-18-2008, 07:30 PM
I didn't write any of the code. It has come from Word 2003's convert to web page. and put through a further filter.
I know it's crap, but I don't have the time or skill to use it as it is. I could labouriously convert the inline code to divs, but as I don't have any faith in this existing code, I would rather make a fresh start. If you think this code is awful, you should see what came out of Word!

If I have an outline of what to do, I can probably do it, but as I explained, that is one skill that I lack. I am not a good organiser. As I am expected to maintain and update this site, I want to start with valid code. Using the validator only convinced me of the need to start from scratch. Well, back to the drawing board. Thank for your reply.

By the way, I normally leave the css in the head section while developing and then move it to a separate file when finished.

Frank

tomws
07-18-2008, 07:51 PM
If it's supposed to be an article type site (as it appears it might be), then why not go with a CMS and a decent included template? That would take care of the code in one fell swoop AND allow Ms Goonewardene to login and post her own writings. As it is, at least on the surface, there's nothing worth keeping except the textual content anyway.

_Aerospace_Eng_
07-18-2008, 07:53 PM
Go through the page and look for sections of that could be split up and put on a page of its own.

Once you do this find a free template somewhere maybe churched themed or something.

Make sure its a CSS template and that it doesn't use tables. After you've found your theme start creating the pages by copying the template over and over.

If you have to you can use php includes but if its small you won't really need to use includes as you could just edit the menu if you needed to.

If you have Dreamweaver you can use his templating abilities. By that I mean you can create a new template with whatever code you want. Any change you make to the template will be made through out the site. If you don't have Dreamweaver ignore this part.

Now once you have your pages created start taking the text out of the document and put them into paragraphs arranging them similar to how they are. You can keep the images as well. You can have text wrap around any image if you put the image before the paragraph and float it to the left or right. Your choice.

I know it sounds like a lot of work but maybe you could post in the partners/collaboration forum as there may be someone who would help you for free especially if they are trying to build up their portfolio.

effpeetee
07-18-2008, 07:56 PM
If it's supposed to be an article type site (as it appears it might be), then why not go with a CMS and a decent included template? That would take care of the code in one fell swoop AND allow Ms Goonewardene to login and post her own writings. As it is, at least on the surface, there's nothing worth keeping except the textual content anyway.
Yes, I think you are right. The lady has grandiose ideas that she will make money from this venture as well as spreading the word. I'm afraid that she is in for a disappointment, but I don't want to discourage her. I'll look round and see what's available.

Thanks for you input. It is all helpful.

Frank

effpeetee
07-18-2008, 08:04 PM
Thanks Aero.

I will definitely have a go at building the site. But I will have to get something up pro-tem to keep her happy. I'd much rather have my own code and will do so. I believe my editor has template facilities.

Now,I'll have to dissuade her from sending me the design all ready made up in Word.

Regards,

Frank

bazz
07-19-2008, 03:50 AM
Frank I hope this helps to make it easier to re-code. I have taken out all the bumph and put the various elements into what I consider to be, their correct tags.

bazz

macwiz
07-19-2008, 03:53 AM
That CSS should be made external. Much easier to change if it is for more than one page.

effpeetee
07-19-2008, 08:33 AM
That CSS should be made external. Much easier to change if it is for more than one page.

I only leave the stylesheet there until I have finalised the page. THEN I transfer it to an external sheet.

However, I am still having problems. Slowly trying to get the page v alid, I am defining divs and classes. I am currently stuck with the first headline.
I have defined h1 to be red and centered yet the headline refuses to obey.
Can anyone tell me why?:confused:
This is the site. (http://exitfegs.co.uk/atest.html)

I know that it is invalid.

Frank

FWDrew
07-19-2008, 08:43 AM
You haven't set the style properly for your h1 tags.

Change this:

.h1{color:red;
text-align:center; }

to this:

h1{color:red;
text-align:center; }

Note the absence of the period in the second code, you were declaring a class called h1, not setting the styles for the h1 tags.

Best Regards,

Drew

effpeetee
07-19-2008, 08:57 AM
Many thanks. Due to my poor eyesight. I didn't notice the dot. I must be going "dotty"

Thanks again, Still a lot of work to do.

Frank

FWDrew
07-19-2008, 08:58 AM
No worries Frank, best of luck with the site.

Regards,

Drew

effpeetee
07-19-2008, 10:45 AM
I think I'll have to admit defeat.I just cannot get it right. It's such a mess.

despondent Frank

Millenia
07-19-2008, 11:07 AM
I think I'll have to admit defeat.I just cannot get it right. It's such a mess.

despondent Frank

Don't give up :(

Why not try using a CMS?

effpeetee
07-19-2008, 11:43 AM
I'd need to get a CMS program and then learn it. With my bad eyesight that would be a challenge in itself. I'll just have to get a suitable layout and do the best I can with it.

Thanks for the encouragement.

Frank

Millenia
07-19-2008, 11:57 AM
I'd need to get a CMS program and then learn it. With my bad eyesight that would be a challenge in itself. I'll just have to get a suitable layout and do the best I can with it.

Thanks for the encouragement.

Frank

Why not work from a template?
Freewebtemplates.com (http://www.freewebtemplates.com)

effpeetee
07-19-2008, 01:24 PM
Why not work from a template?
Freewebtemplates.com (http://www.freewebtemplates.com)
I have sorted it out and it validates.

But I would still welcome advice as to layout.

Check it here, (http://exitfegs.co.uk/ANGELA1.html)

That's a load off my mind.

Thank you all for your help, I do appreciate it.

Frank

macwiz
07-19-2008, 05:29 PM
I would set a right margin. The text goes right up to the edge of my browser window.

harbingerOTV
07-19-2008, 05:58 PM
Ditto.

I would wrap the whole shebang in a wrapping div and set it for like 80% width. Good job though Frank cleaning it up ;)

effpeetee
07-19-2008, 06:21 PM
As I already had a left margin, I just added a right margin to balance and give space. 3&#37; each side.

harbingerOTV : How would I do the wrapper. Would I put it before <body> or after it.
My css is still at primary level?

Thanks all for your help.

Frank

harbingerOTV
07-19-2008, 06:42 PM
Frank,

if you're just margin/padding the body there isn't really a need but to apply a wrapper, add it after the body tag lik:


<body>
<div id="wrap">
stuff here
</div>
</body>


-Alan

effpeetee
07-19-2008, 09:59 PM
Frank,

if you're just margin/padding the body there isn't really a need but to apply a wrapper, add it after the body tag lik:


<body>
<div id="wrap">
stuff here
</div>
</body>


-Alan
I've done it just for the practise. It worked fine and I have left it that way now.

Regards,

rank



EZ Archive Ads Plugin for vBulletin Copyright 2006 Computer Help Forum