View Full Version : How does my code look>?
09-20-2007, 08:10 PM
How does my coding look?
I know I have only done the splash page but I wanted to be sure I was doing things right before I moved on and reused some of my code. By right I mean semantically.
09-20-2007, 08:40 PM
Wow, that code is a feast for my spoiled eyes. :) Itís heart-warming to see such nicely written, semantic, and well formatted code among the crap that I come across each day.
The design is beautiful as well, by the way. :)
One question, though: Why is the page title (headline 1) in a list within a div in the header? Thatís about the only thing that doesnít really makes sense (has no semantic meaning). And youíre not even using it to apply styles. Hence, the list and the div with ID logo ainít necessary at all. Oh and the same goes for the navigation. The wrapping div is not necessary.
Iíd also suggest to use ďskip to content/topĒ links for accessibility which you hide for screen layouts (but will be visible e.g. for small screen devices).
Well, now that Iím looking closer (and with styles disabled) I see that you have been using headlines for all your content. Why is that? Headlines are only meant forÖ well, headlines. If you look at it without styles itís gotta make sense as well. This also means that you should put the website screenshots as actual images into the HTML. A headline can be used for the project name/title but the rest should be regular text (in divs or lists if that applies). Have a look at my portfolio (http://vipstephan.de/portfolio.htm) to get an idea (and look at it in Firefox or Opera with styles switched off). I also separated the projects with a horizontal rule.
But after all, good work!
Looks good. Its nice to see someone else that indents.
You wouldn't believe all crappy code I see on a regular basis at work.
I see no indentation, no CSS, and non-semantic garbage.
09-20-2007, 08:56 PM
Great :) Thanks for all your help! I am still pretty new to xhtml css layouts so I'm happy to see that I'm doing things right! Ill make the header adjustments the only reason I used them is because I thought it was important for SEO use not semantics.
Powered by vBulletin® Version 4.2.2 Copyright © 2017 vBulletin Solutions, Inc. All rights reserved.